Fix figure not properly closed in CodeExercise with parameters #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a CodeExercise with parameters is created the `<Figure size 640x480 with 0 Axes>` the CueFigure is created. I am not sure why this happens. It could be related to interact. It can be fixed by moving the CueFigure creation before the ParameterPanel creation
agoscinski
force-pushed
the
fix-figure-shown
branch
from
c82e71f to
8510b01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a CodeExercise with parameters is created and a figure is created the
<Figure size 640x480 with 0 Axes>is displayed. This is prevented by closing the figure whenCueFigureis created. I am not sure why this happens. It could be related to interact. It can be fixed by moving the CueFigure creation before the ParameterPanel creation.📚 Documentation preview 📚: https://scicode-widgets--94.org.readthedocs.build/en/94/