Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore mypy errors related to CueWidget #98

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

agoscinski
Copy link
Collaborator

@agoscinski agoscinski commented Dec 17, 2024

mypy cannot infer the correct type of traits_to_observe in CueWidget init constructor after if checks so we ignore it. Further there are problems with types of List[A | B] when wants to assign them with a variable of type List[A]. We ignore these cases too.

Fix types from Union[List[str], List[Sentinel], List[List[str]]] to List[Union[str, Sentinel, List[str]]].


📚 Documentation preview 📚: https://scicode-widgets--98.org.readthedocs.build/en/98/

mypy cannot infer the correct type of traits_to_observe in CueWidget
init constructor after if checks so we ignore it. Further there are
problems with types of List[A | B] when wants to assign them with a
variable of type List[A]. We ignore these cases too.

Fix types from Union[List[str], List[Sentinel], List[List[str]]] to
List[Union[str, Sentinel, List[str]]]
@agoscinski agoscinski merged commit 0c30bdb into main Dec 18, 2024
2 of 4 checks passed
@agoscinski agoscinski deleted the add-type-ignores branch December 18, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant