-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charter for review #228
Charter for review #228
Conversation
@oliverchang has the project had enough time to review the charter? Any thoughts or changes needed? We are hoping to close out the charter. |
Signed-off-by: Amanda L Martin <[email protected]>
Any other concerns with the charter that stops us from approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. This generally seems good.
@rsc @chrisbloom7 have been the two other main contributors to this project. Any thoughts?
I have no issue with this 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to have date charter was adopted entered prior to merging
Working with LF legal, they don't want this charter merged, so there is no date. We are using GitHub in hopes of getting the approval and adopting the date of the last approval, and then we can upload it as a PDF. |
Apologies for the delay, I thought I already approved it in #228 (review) |
You indeed have. Do we need approval from @rsc to close it out or can I move this to closed? |
LGTM thanks. |
I am closing this PR as I do not have write access any longer to make the needed changes. The charter that should be added is here: OSV Schema Technical Charter.pdf |
This PR resolves #224
The mission specifically needs review.