Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charter for review #228

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Charter for review #228

merged 2 commits into from
Aug 7, 2024

Conversation

hythloda
Copy link
Member

This PR resolves #224
The mission specifically needs review.

@hythloda hythloda requested a review from oliverchang February 25, 2024 22:14
@hythloda
Copy link
Member Author

@oliverchang has the project had enough time to review the charter? Any thoughts or changes needed? We are hoping to close out the charter.

Signed-off-by: Amanda L Martin <[email protected]>
@hythloda hythloda requested a review from oliverchang March 26, 2024 13:58
@hythloda
Copy link
Member Author

Any other concerns with the charter that stops us from approval?

Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. This generally seems good.

@rsc @chrisbloom7 have been the two other main contributors to this project. Any thoughts?

@chrisbloom7
Copy link
Contributor

I have no issue with this 👍🏻

Copy link

@SecurityCRob SecurityCRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to have date charter was adopted entered prior to merging

@SecurityCRob SecurityCRob added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 5, 2024
@hythloda
Copy link
Member Author

hythloda commented Jun 5, 2024

need to have date charter was adopted entered prior to merging

Working with LF legal, they don't want this charter merged, so there is no date. We are using GitHub in hopes of getting the approval and adopting the date of the last approval, and then we can upload it as a PDF.
The reason for this is that when it isn't a pdf people have made changes to charters in other groups and then there is the official charter stored with legal and a different one on GitHub.

@oliverchang
Copy link
Contributor

Apologies for the delay, I thought I already approved it in #228 (review)

@hythloda
Copy link
Member Author

hythloda commented Jun 7, 2024

Apologies for the delay, I thought I already approved it in #228 (review)

You indeed have. Do we need approval from @rsc to close it out or can I move this to closed?

@rsc
Copy link

rsc commented Jun 8, 2024

LGTM thanks.

@hythloda hythloda mentioned this pull request Jul 22, 2024
@hythloda
Copy link
Member Author

I am closing this PR as I do not have write access any longer to make the needed changes. The charter that should be added is here: OSV Schema Technical Charter.pdf

@hythloda hythloda closed this Jul 22, 2024
@oliverchang oliverchang reopened this Aug 7, 2024
@oliverchang oliverchang merged commit 9a67a38 into main Aug 7, 2024
3 checks passed
@oliverchang oliverchang deleted the adds-charter branch August 7, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposed legal & governance improvements for the OpenSSF
5 participants