Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libotutil: Remove redundant import of prctl.h #3375

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

fossdd
Copy link
Contributor

@fossdd fossdd commented Jan 27, 2025

sys/prctl.h already provides prctl.h and adding both imports fails on musl libc:

/usr/include/sys/prctl.h:88:8: error: redefinition of 'struct prctl_mm_map'
   88 | struct prctl_mm_map {
      |        ^~~~~~~~~~~~
In file included from src/libotutil/ot-unix-utils.c:33:
/usr/include/linux/prctl.h:134:8: note: originally defined here
  134 | struct prctl_mm_map {
      |        ^~~~~~~~~~~~

sys/prctl.h already provides prctl.h and adding both imports fails on
musl libc:

	/usr/include/sys/prctl.h:88:8: error: redefinition of 'struct prctl_mm_map'
	   88 | struct prctl_mm_map {
	      |        ^~~~~~~~~~~~
	In file included from src/libotutil/ot-unix-utils.c:33:
	/usr/include/linux/prctl.h:134:8: note: originally defined here
	  134 | struct prctl_mm_map {
	      |        ^~~~~~~~~~~~
Copy link

openshift-ci bot commented Jan 27, 2025

Hi @fossdd. Thanks for your PR.

I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cgwalters
Copy link
Member

/ok-to-test

@cgwalters cgwalters enabled auto-merge January 27, 2025 18:06
@cgwalters cgwalters merged commit c0f8db1 into ostreedev:main Jan 27, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants