Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GIR #3376

Merged
merged 4 commits into from
Feb 1, 2025
Merged

Update GIR #3376

merged 4 commits into from
Feb 1, 2025

Conversation

Mstrodl
Copy link
Contributor

@Mstrodl Mstrodl commented Jan 30, 2025

(And regenerate rust bindings)

Copy link

openshift-ci bot commented Jan 30, 2025

Hi @Mstrodl. Thanks for your PR.

I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions github-actions bot added the area/rust-bindings Relates to the Rust bindings for the C library label Jan 30, 2025
@cgwalters
Copy link
Member

Thank you! I think this may just be missing a cargo fmt?

@cgwalters
Copy link
Member

Alternatively, hmm maybe we should just #[rustfmt::skip] on all the generated code?

@cgwalters cgwalters force-pushed the feature/mstrodl/update-gir branch from 5770e7e to f8a57ba Compare February 1, 2025 15:53
@cgwalters
Copy link
Member

Thank you! I think this may just be missing a cargo fmt?

I went ahead and pushed this.

@cgwalters cgwalters enabled auto-merge February 1, 2025 16:20
@cgwalters
Copy link
Member

/override ci/prow/fcos-e2e
(duplicate)

Copy link

openshift-ci bot commented Feb 1, 2025

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/fcos-e2e

In response to this:

/override ci/prow/fcos-e2e
(duplicate)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cgwalters cgwalters merged commit 968b0b1 into ostreedev:main Feb 1, 2025
25 checks passed
@cgwalters cgwalters mentioned this pull request Feb 1, 2025
@Mstrodl
Copy link
Contributor Author

Mstrodl commented Feb 4, 2025

Oops sorry. Only just saw this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rust-bindings Relates to the Rust bindings for the C library needs-ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants