-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with integer keys #8
Conversation
I'm not sure it's the best solution. Should be somewhere around here: And here as well (for |
Hmm... I didn't know that this worked on lists too. However, I don't see how the parser can be left alone if the integer key has to be supported for an object because it seems as if the lexer tokenizes a key if it starts with a letter and the parser doesn't seem to know how to parse a dot followed by a number at the moment (please correct me if I have missed something). I'd be willing to change my PR to work with lists though by modifiying the files you said though! |
I mean, it should be ok to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks! Ping @vanadium23
Previously, a query such as
$.3
would fail. This PR fixes this problem.This also fixes one of the issues in #6.