Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to MuJoCo 2.1.0 #8

Open
wants to merge 1 commit into
base: mujoco150
Choose a base branch
from
Open

Conversation

liuliu
Copy link

@liuliu liuliu commented Dec 5, 2021

This PR switched Cassie simulator to use MuJoCo 2.1.0, which, after
DeepMind acquisition is open-source and open access now.

Because mjv_makeScene will free the previous scn, switched v allocation
from malloc to calloc too. Otherwise using 2.1.0 will crash on start.

Test Plan:

Run make test, and run test/cassietest.py, before this PR, it
requires MuJoCo 1.5, now MuJoCo 2.1 worked and runs.

This PR switched Cassie simulator to use MuJoCo 2.1.0, which, after
DeepMind acquisition is open-source and open access now.

Because mjv_makeScene will free the previous scn, switched v allocation
from malloc to calloc too. Otherwise using 2.1.0 will crash on start.

Test Plan:

Run `make test`, and run `test/cassietest.py`, before this PR, it
requires MuJoCo 1.5, now MuJoCo 2.1 worked and runs.
@@ -37,16 +37,15 @@ build: $(LIBOUT)
cp -r model/* build/

ctypes: build
clang2py include/*.h --clang-args="-I/usr/include/clang/6.0/include -Iinclude" -l ./$(LIBOUT) -o build/cassiemujoco_ctypes.py
clang2py include/*.h --clang-args="-I/usr/include/clang/10/include -Iinclude" -l ./$(LIBOUT) -o build/cassiemujoco_ctypes.py
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's the best way to update this. I happens to use clang 10.

@liuliu
Copy link
Author

liuliu commented Dec 6, 2021

Just noticed the major development happens on realtime_vis branch. Will try to upgrade that branch to 2.1.0 (such that everyone who checks out can use MuJoCo without license issues) instead.

Minor suggestion: making the actively developed branch your default one, such that people aware this repo is active.

@N1ckfm
Copy link

N1ckfm commented Dec 8, 2021

I can run cassie on 210 mujoco but my question is when I test cassietest.py I only see the robot fall down for gravity. How can I test the reinforcement learning training with Cassie?

@SB-Moloo
Copy link

I can run cassie on 210 mujoco but my question is when I test cassietest.py I only see the robot fall down for gravity. How can I test the reinforcement learning training with Cassie?

Do you have refuse it? I have a same problem!

@liuliu
Copy link
Author

liuliu commented Apr 22, 2022

My understanding is this for the Cassie simulation. It doesn't have the PPO training nor the LSTM model code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants