Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes fields from collections #1766

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Removes fields from collections #1766

merged 2 commits into from
Nov 8, 2018

Conversation

straleyb
Copy link
Contributor

@straleyb straleyb commented Nov 8, 2018

This is the first step in fixing #1751 There is some more work to be done to fix that ticket completely. A separate ticket for adding nested related items to the collection model.

revgum
revgum suggested changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@revgum revgum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point out in this override where you have made customizations?

@revgum revgum merged commit 47b08f7 into master Nov 8, 2018
@revgum revgum deleted the feature/RemoveFieldsFromCollections branch November 8, 2018 17:45
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.889% when pulling 3c43a2a on feature/RemoveFieldsFromCollections into 5f246da on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revgum revgum revgum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@straleyb @coveralls @revgum