Add support for generating easy to read passwords #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
I accidentally included this in the initial commit to the branch.
|
Code Climate has analyzed commit a3b0c8d and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alexander,
I like the "easy to read" option of the LastPass password generator so I wanted to add that to this workflow as another password format.
It excludes some alphanumeric characters which can be ambiguous to the human eye (e.g.,
O,0,1,l) especially when the password is displayed in a font that isn't fixed-width. It also excludes some special characters which (to me) make the password look too complicated.Let me know what you think. I'll be happy to update the PR based on your feedback.
If you agree to merge this PR, we'll need to recreate the screenshot and gif as well.