add a shared namespace #56

RobinQu · 2015-12-23T03:15:22Z

No description provided.

othiym23 · 2016-01-29T18:52:09Z

What's the use case behind this? In principle, I have no objection, but I'd like to understand what you're trying to do. Also, before this gets merged, it'll need tests and documentation.

binki · 2016-09-29T05:30:19Z

context.js

+  reset            : reset,
+  getSharedNamespace: function () {
+    if (!process.sharedNamespace) {
+      process.sharedNamespace = create('shared_' + Date.now() + '_' + Math.random());


Instead of generating a random name and leaving things to chance, why not consider doing it right and implementing anonymous namespaces as I requested in #52?

binki · 2016-09-29T05:34:26Z

Instead of some “shared namespace” why not just use an agreed-upon namespace name? I agree with @othiym23, the goal of this PR is unclear and the only use cases I can guess at are nonsensical.

long.qul added 3 commits December 23, 2015 11:09

add a shared namespace

c359107

add tnpm publish config

13013aa

bump ver

b9f45b1

othiym23 added needs tests needs docs needs discussion labels Jan 29, 2016

binki reviewed Sep 29, 2016

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add a shared namespace #56

add a shared namespace #56

RobinQu commented Dec 23, 2015

othiym23 commented Jan 29, 2016

binki Sep 29, 2016

binki commented Sep 29, 2016

add a shared namespace #56

Are you sure you want to change the base?

add a shared namespace #56

Conversation

RobinQu commented Dec 23, 2015

othiym23 commented Jan 29, 2016

binki Sep 29, 2016

Choose a reason for hiding this comment

binki commented Sep 29, 2016