-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds localisation support! #37
Merged
othyn
merged 14 commits into
dev
from
36-as-a-user-i-would-like-support-for-localisation
Jul 11, 2022
Merged
Adds localisation support! #37
othyn
merged 14 commits into
dev
from
36-as-a-user-i-would-like-support-for-localisation
Jul 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove arbitrary limits on custom fields
… > Edit Scheme... > Select 'Run' on the left, then on the right side select the Options tab and then select 'Localization Debugging', then 'Close')
…l editor of the xcodeproj file)
…calisations...' is usable
…m for cross-macOS version support
…uired as the OS remembers the window state, but it lays the ground work should this want to be read from there in future!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces out all en-GB string instances with localised variants, laying the ground work for further language expansion. Along with this there are a few UI updates to best support this.
Related Issue
Closes #36
Required for #10
Motivation and Context
Makes the application far more accessible to more people.
How Has This Been Tested?
Manually, as there is no current automated test suite. Checking all occurances of the english language and using the 'Product > Export localizations...' option to to dump the current localisations and making sure that they are all covered.
Types of changes
Checklist