Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds localisation support! #37

Merged
merged 14 commits into from
Jul 11, 2022

Conversation

othyn
Copy link
Owner

@othyn othyn commented Jul 11, 2022

Description

Replaces out all en-GB string instances with localised variants, laying the ground work for further language expansion. Along with this there are a few UI updates to best support this.

Related Issue

Closes #36
Required for #10

Motivation and Context

Makes the application far more accessible to more people.

How Has This Been Tested?

Manually, as there is no current automated test suite. Checking all occurances of the english language and using the 'Product > Export localizations...' option to to dump the current localisations and making sure that they are all covered.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@othyn othyn added the enhancement New feature or request label Jul 11, 2022
@othyn othyn added this to the v1.4.0 milestone Jul 11, 2022
@othyn othyn self-assigned this Jul 11, 2022
@othyn othyn linked an issue Jul 11, 2022 that may be closed by this pull request
@othyn othyn changed the base branch from main to dev July 11, 2022 10:48
@othyn othyn merged commit 24db800 into dev Jul 11, 2022
@othyn othyn deleted the 36-as-a-user-i-would-like-support-for-localisation branch July 11, 2022 20:30
@othyn othyn modified the milestones: v1.4.0, v1.3.3 Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

As a user, I would like support for localisation
1 participant