Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate sinkdiv to Monge gap implementation #597

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

marcocuturi
Copy link
Contributor

make sure sinkhorn_divergence.sinkdiv is used in Monge gap related scripts / tests / tutorials

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.90%. Comparing base (86e8f2c) to head (9455013).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   88.17%   87.90%   -0.28%     
==========================================
  Files          73       73              
  Lines        7770     7770              
  Branches      556      556              
==========================================
- Hits         6851     6830      -21     
- Misses        778      799      +21     
  Partials      141      141              
Files with missing lines Coverage Δ
src/ott/neural/methods/monge_gap.py 91.20% <ø> (ø)

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@marcocuturi marcocuturi merged commit fd18299 into main Nov 18, 2024
8 of 12 checks passed
@marcocuturi marcocuturi deleted the prop-sinkdiv branch November 21, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant