solve tests for soft-sort / unb. Bures + add xlim/ylim options in plot #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcocuturi
changed the title
|
a few more tests are failing, but merging for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor fixes to solve some of the tests failing due to errors, notable
test_ranksandtest_bures_point_cloudtest_ranksfixed due to overzealous tolerance (soft ranks are reals in[0,n-1]for a vector of sizen, that should look like corresponding integers, but cannot in general, due to regularization and in other scenarios where there is a number of targets that's different fromn, be that close)test_bures_point_cloud: the order of magnitude of covariance matrices was too large, with dets in the thousands, which resulted in numerical instability.also adds ability to set static
xlimandylimin plot tool to set a scale when using animations.