Add OTCP #612
Draft
Add OTCP #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcocuturi
reviewed
Feb 27, 2025
|
|
||
| Args: | ||
| model: Fitted model. | ||
| is_classifier: Whether ``model`` is a classifier or a regressor. |
There was a problem hiding this comment.
do we really need this? couldn't this be contained simply in the score choice? i also envision many more score functions than the two that are defined here, and so it seems having this boolean flag will quickly be insufficient.
I feel that the simplest would be to just assume that model outputs a real vector, and that score takes that vector, x and y and does whatever it wants with it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements approach outlined in https://arxiv.org/abs/2502.03609
TODOs