Update save_conversations tool
#1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taenin
approved these changes
Feb 11, 2025
| @@ -65,13 +66,83 @@ def _load_sft_dataset( | |||
| return dataset | |||
|
|
|||
|
|
|||
| def _split_message_list_on_user(messages: list[Message]) -> list[list[Message]]: | |||
| turn_start_indices: list[int] = [] | |||
There was a problem hiding this comment.
Food for thought here: should you add a check for an empty input? I think _split_message_list_on_user([]) should return [] not [ [] ]
src/oumi/core/types/conversation.py
Outdated
| """Gets all messages in the conversation, optionally filtered by role. | ||
|
|
||
| Args: | ||
| role: The role to filter messages by. | ||
| If None, returns all messages. | ||
| If None, no filtering by role is applied. |
There was a problem hiding this comment.
This implies that the filter_fn has to use to role field, which isn't necessarily true.
There was a problem hiding this comment.
Added Optional to make it more clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-- Add flags to split multi-turn conversations into N single-turn conversations
-- Modify
Conversation.filter_messages()method to accept user-defined predicate.Related issues
Towards OPE-355
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staffis required.