-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Argo Events in Azure, setting version numbers in variables.tf #33
Draft
bbrandt
wants to merge
8
commits into
outerbounds:master
Choose a base branch
from
bbrandt:kevsmith/argo-events-azure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This allows the service principal to be managed by a user well less privileges.
bbrandt
changed the title
Install Argo Events, setting version numbers in variables.tf
Install Argo Events in Azure, setting version numbers in variables.tf
Mar 3, 2023
@bbrandt Overall looks quite reasonable to me. Did you get a chance to use this PR in practice? To set some expectations: Events triggering support is very close to merge. Once that is merged (perhaps by next week), I plan to also try out this PR as a kind of UAT (inclusive of exercising the said Metaflow eventing code). Then we would be in a good position to merge this PR. |
This is the testing I've done:
Not tested:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of #19 with latest master merged and conflicts resolved. Moved version numbers for Argo and Argo events to variables.tf.
Draft PR #34 can be reviewed to verify the merge and conflict resolution was correct.