-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh Metaflow charts and create a github pages to host them #60
base: master
Are you sure you want to change the base?
Conversation
c75f08a
to
2d838d4
Compare
|
||
image: | ||
pullPolicy: IfNotPresent | ||
repository: public.ecr.aws/outerbounds/metaflow_metadata_service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there some automation regarding the release of this image? OSS only releases under netflixoss/metaflow_metadata_service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have a pipeline that listens to the repository and publish builds to ecr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#50 might still be a relevant change for this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also one big stumbling block for people deploying on RDS with a new (v15+ IIRC) postgres engine is that the metadata/ui-backend versions default to no ssl connection for the db, but later versions of postgres have started to mandate this.
It would be a good idea to include this env var in the templates for the services, to ensure db connectivity in case users start off with the provided postgres, but later on switch to RDS:
MF_METADATA_DB_SSL_MODE=prefer
see #58 for similar fixes regarding cloudformation
Added a default in values.yaml: 80cd398 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved pending testing results. the charts seem to apply correctly on a minikube cluster at least :)
No description provided.