elaborate on error "Expected Sink" #15234
Open
+194
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this code snippet.
This used to throw Expected Sink, but now throws a more accurate error message:
Closes #10632. the author should add
await
, an example of this is withinssr.tsx
, it uses the controller out of the scope but also contains a promise thatpull
returns.This PR also fixes the bug causing this, and writes being truncated, in the bake framework for react