-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode-extension) error reporting, qol #15261
Conversation
a393fad
to
93b52be
Compare
Co-authored-by: Electroid <[email protected]> Co-authored-by: Meghan Denny <[email protected]>
…lems in user src and node_modules
} | ||
|
||
for (size_t i = 0; i < exception.stack.frames_len; i++) { | ||
ZigStackFrame* frame = &exception.stack.frames_ptr[i]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, I think we can get the function name from frame
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, we'd need to add this to the inspector event. Probably can't guarantee that we'll always have it (@Jarred-Sumner ?)
cc @Jarred-Sumner @dylan-conway |
Yup, this is a new test failure, looking into it. I believe the cause is from https://github.com/oven-sh/bun/pull/15261/files#diff-36302f74ed5420c7bee6a5460115be29fd82720720381c0d2c8bb7c934e69591L382 |
This code (or at least something similar iirc) was removed previously, I think because it was printing errors twice. Did you test this locally and if so does it seem to be working? I can try it out as well to test |
What does this PR do?
A few goodies implemented into the VSCode extension.
node:net
SocketHow did you verify your code works?
Ran extension and tested each feature
Notes:
.relatedInformation
for each diagnostic. Right now we just show the error message again. This isn't amazing...BUN_INSPECT_NOTIFY
variable to''
. A use case for disabling would be like when running a benchmark file (where this would actually have a very very slight performance overhead)