-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace placeholder URLS with commandline variables #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this change. The lms-url and studio-url are supposed to be the internal URL used for communication between containers, right?
@regisb If that is the case, then I severely misunderstood the code, and therefore the error/issue (#86) that made me open this PR. I'm awaiting confirmation on this if possible, then I will close the PR. |
No worries. I think you misunderstood the code. The "lms:8000" hostnames are definitely not placeholders. It might be that we need to pass public URLs to the initialization scripts, in which case we would be very wrong, but so far this code has worked, so I'm inclined to think that if there is an issue, then the solution lies elsewhere. |
Alright, I will close this and the issue as well. |
I reported this issue here #85 , this PR should fix it