-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutor Indigo Theme Updates #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this preliminary PR Hina. I see that we are overriding many html templates. If we do not take some precautions it's going to be extremely difficult to upgrade those in the future. Can we keep our html changes to a minimum? And where changes are needed, clearly label them with an HTML comment.
Regis, We've removed the static files which we haven't overridden. Also, Not a lot of changes we've made but comments has been added by Tanveer where he made changes in the |
tutorindigo/templates/indigo/lms/templates/courseware/course_about.html
Outdated
Show resolved
Hide resolved
f5c29a3
to
df5f11a
Compare
This is awesome work. I'm eager to see this live. landing pageWhen unauthenticated, the "explore courses" menu in the top left corner looks off: faviconI think we should not use the "" logo for the favicon: it's not neutral enough. Instead, we should use the blue "<>" logo: course about pageIn the course "about" page, when I hover on the social sharing links, the "Share with friends and family" modal looks off. The background should not be black, the font should not be serif and not italic: |
Closed in favour of #54 |
No description provided.