feat: add patch at the end of the production layer #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mfe-dockerfile-production-final` patch allows you to add instructions to the end of the final layer. This is useful in the case you want to override the default CMD or ENTRYPOINT instructions.
regisb
approved these changes
Jan 8, 2024
|
Thanks for this PR @MoisesGSalas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
mfe-dockerfile-production-finalpatch allows you to add instructions to the end of the final layer. This is useful in the case you want to override the default CMD or ENTRYPOINT instructions.Additional info
I think the patch will be useful overall, but my use case is as follows:
I've been exploring the idea of pointing
Public Pathto a cloudfront endpoint to speed up the MFE asset delivery. The only problem is that I can't reuse the image between environments because the cloudfront endpoint is hardcoded at build time. What I've been playing around is to use a placeholder string as thePUBLIC_PATHand run a startup script in the container that replaces the placeholder with a value set in an environment variable.