feat: add course authoring mfe base url to env vars #182
Conversation
There was a problem hiding this comment.
Thanks for your contribution! Can you please add a changelog entry? https://docs.tutor.overhang.io/tutor.html#contributing
rpenido
force-pushed
the
rpenido/add-course-authoring-mfe-base-url
branch
from
4407799 to
85abfde
Compare
|
Done! |
| @@ -38,6 +38,7 @@ MFE_CONFIG["ACCOUNT_SETTINGS_URL"] = ACCOUNT_MICROFRONTEND_URL | |||
| {% if get_mfe("course-authoring") %} | |||
| MFE_CONFIG["ENABLE_NEW_EDITOR_PAGES"] = True | |||
| MFE_CONFIG["ENABLE_PROGRESS_GRAPH_SETTINGS"] = True | |||
| MFE_CONFIG["COURSE_AUTHORING_MFE_BASE_URL"] = "http://{{ MFE_HOST }}:{{ get_mfe("course-authoring")["port"] }}" | |||
There was a problem hiding this comment.
@rpenido Shouldn't this be "http://{{ MFE_HOST }}:{{ get_mfe("course-authoring")["port"] }}/course-authoring" ? That seems more consistent with all of the other MFE _URL variables in this file.
Also, there seems to be some inconsistency about whether these have a trailing slash or not, but most of them (except account and learner-dashboard) do not so that's probably the way to go.
There was a problem hiding this comment.
To give some context, we are using this in the iFrame.
We are using the COURSE_AUTHORING_MFE_BASE_URL here: https://github.com/openedx/frontend-app-library-authoring/pull/400/files
We have the url /course-authoring in the COURSE_AUTHORING_MICROFRONTEND_URL variable already set here:
But this URL renders an error to me:
http://apps.local.edly.io:2001/course-authoring/home
The course authoring URL in my tutor instance is the following:
Is there some misconfiguration on my side?
PS: Feel free to close this is this is not the right way to fix it
There was a problem hiding this comment.
It's actually a bug in the course authoring MFE: openedx/frontend-app-authoring#784
"Studio Home" should be showing at http://apps.local.overhang.io:2001/course-authoring/home (or edly.io)
So I think COURSE_AUTHORING_MICROFRONTEND_URL is all you need, and you can close this PR.
|
Thank you @bradenmacdonald! |
Description
This PR adds the "COURSE_AUTHORING_MFE_BASE_URL" env var pointing to the Course Authoring MFE address.
Additional Info
We are rendering a course authoring URL in an iFrame inside the library authoring as part of the Tagging Project, so we need to know the Course Authoring MFE address.