Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow removal of course-authoring mfe #190

Conversation

Danyal-Faheem
Copy link
Contributor

Fixes #189.

Added a small check to make sure course-authoring is in the MFE_APPS before changing the settings.

@Danyal-Faheem Danyal-Faheem self-assigned this Feb 13, 2024
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arbrandes arbrandes merged commit f3131b1 into overhangio:master Feb 15, 2024
1 check passed
@Danyal-Faheem Danyal-Faheem deleted the Danyal-Faheem/fix-course-authoring-mfe-removal branch February 16, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Removing the Course-Authoring MFE throws an error during env rendering
3 participants