-
Notifications
You must be signed in to change notification settings - Fork 446
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Use new template var TUTOR_BRANCH_IS_MAIN to fix a patching bug
- Loading branch information
1 parent
ec260f4
commit 463c5a3
Showing
3 changed files
with
5 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- [Feature] Add the `TUTOR_BRANCH_IS_MAIN` variable to the template context, which is set to True for users running Tutor Main (by @kdmccormick). | ||
- [Bugfix] Use `TUTOR_BRANCH_IS_MAIN` rather than the edx-platform branch name in order to determine which patches to apply. This way, when developers are testing an edx-platform branch that is not master but which may be *based on* master, they will receive master patches rather than release patches, assuming they are running Tutor Main in the first place (by @kdmccormick). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,10 +49,10 @@ RUN git config --global user.email "[email protected]" \ | |
{%- if patch("openedx-dockerfile-git-patches-default") %} | ||
# Custom edx-platform patches | ||
{{ patch("openedx-dockerfile-git-patches-default") }} | ||
{%- elif EDX_PLATFORM_VERSION == "main" %} | ||
{%- elif TUTOR_BRANCH_IS_MAIN %} | ||
# Patches in Main node | ||
{%- else %} | ||
# Patches in non-Main mode | ||
# Patches in non-Main mode (i.e., Release mode) | ||
{%- endif %} | ||
|
||
{# Example: RUN curl -fsSL https://github.com/openedx/edx-platform/commit/<GITSHA1>.patch | git am #} | ||
|