-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to quince #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an openedx/edx-platform commit backported as a patch to tutor to olive.1 release Since the commit is already merged into edx-platform:master branch used by tutor nightly, there is no further need for it.
Adds `from __future__ import annotations` to the top of every module, right below the module's docstring. Replaces any usages of t.List, t.Dict, t.Set, t.Tuple, and t.Type with their built-in equivalents: list, dict, set, tuple, and type. Ensures that make test still passes under Python 3.7, 3.8 and 3.9.
* Remove redundant changelog line * The change should NOT affect most developers ;)
regisb
force-pushed
the
quince
branch
2 times, most recently
from
November 27, 2023 07:42
874b86f
to
d9de19c
Compare
ziafazal
reviewed
Nov 30, 2023
regisb
force-pushed
the
quince
branch
2 times, most recently
from
November 30, 2023 08:17
2af8981
to
77e59a2
Compare
before this, after enabling/disabling any plugins we should re-generate all files with tutor config save.
Also, update docs on `tutor config save`. Note that we had to fix an issue where the plugin unload callback was being called too late.
The new domain name points to 127.0.0.1, just like the previous one. We keep the local.overhang.io domain names for backward compatibility. In the future, we hope to migrate to "*.openedx.io" but that will not happen before Redwood. Close #945
regisb
force-pushed
the
quince
branch
4 times, most recently
from
December 9, 2023 23:35
b9eae90
to
eec0c01
Compare
regisb
force-pushed
the
quince
branch
5 times, most recently
from
December 11, 2023 18:15
5a8642f
to
4513e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are my notes of the upgrade process.
__about__.py
:__version__ = "17.0.0"
__version_suffix__ = ""
config/defaults.yml
OPENEDX_COMMON_VERSION: "open-release/quince.master"
pip install -e
make upgrade-requirements && pip install -r requirements/dev.txt
is_buildkit_enabled
template filterexport TUTOR_ROOT=~/.local/share/tutor-quince
tutor config save && tutor images build all
tutor local launch
git commit -a -m "feat: upgrade to quince"
TODOs
- [ ] uwsgi is no longer maintained, we should replace it: https://uwsgi-docs.readthedocs.io(postponed to Redwood)