Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renames Ovl for Ov #148

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Renames Ovl for Ov #148

merged 3 commits into from
Jan 16, 2024

Conversation

magnetto90
Copy link
Contributor

Some Ovl references were missed in the previous PR.

EperezOk
EperezOk reviewed Jan 16, 2024
View reviewed changes
Copy link
Contributor

@EperezOk EperezOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The changes on Uniswap feeds will make other PRs (#133) have conflicts, but we can solve those afterwards.

TomasCImach
TomasCImach previously approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@TomasCImach TomasCImach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming changes. OK

TomasCImach
TomasCImach approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@TomasCImach TomasCImach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magnetto90 magnetto90 merged commit 9b02775 into staging Jan 16, 2024
2 checks passed
@magnetto90 magnetto90 deleted the s/rename-token-2 branch January 16, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EperezOk EperezOk EperezOk left review comments

@TomasCImach TomasCImach TomasCImach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magnetto90 @TomasCImach @EperezOk