Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invariant tests and fix dead oi shares bug #176

Merged
merged 17 commits into from
May 20, 2024
Merged

Conversation

EperezOk
Copy link
Contributor

@EperezOk EperezOk commented Feb 1, 2024

No description provided.

@EperezOk EperezOk changed the title Feat/add invariants Improve invariant tests Feb 1, 2024
@EperezOk EperezOk changed the title Improve invariant tests Add invariant tests and fix dead oi shares bug Mar 27, 2024
Copy link
Member

@TomasCImach TomasCImach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing: after unwinding a position, its fractionRemaining can be set to 0 (ie. the position is effectively closed) while its oiShares are still greater than 0.

@TomasCImach TomasCImach merged commit 71a3187 into main May 20, 2024
5 checks passed
@TomasCImach TomasCImach deleted the feat/add-invariants branch May 20, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants