Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BalancerV2 Feed #26
base: main-archive
Are you sure you want to change the base?
BalancerV2 Feed #26
Changes from 61 commits
b7e22e6
a893c39
26bca2d
1317889
9803643
cfd5028
e5c1d69
bfb0210
9255a80
09a8e45
95d9813
1636ef1
821f3d0
0747e9a
752a908
b4e8d31
2923730
0d1ae80
0d6b25a
2de27a5
f8905fa
f0d544d
7ea0e0f
900012a
b6dadf5
25dc402
494a780
e5ef030
5185789
038a8f9
d442252
f37ac70
81e3b0a
58b2165
9d4d77f
16ce2e6
fd8477b
571befa
eb85288
397b6f5
901a0a9
2caca62
0d559fd
b1fc6f7
9a744ce
426ce5c
b55697b
3db3332
259ebdf
39c138f
bb80ced
91a85d9
30202ec
117ac30
902b779
194efa0
444a36f
202e207
2a1ee0f
d31a786
135a75d
4a94e1e
30057e6
e0ca652
05e6693
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing in
BalancerV2Tokens.Info
struct as a deploy feed function input is vulnerable to manipulation: I can deploy a feed with the vault address as my own malicious contract that implements the vault interface, but returns the wrong data to feed.deployFeed()
therefore needs a check that the struct infodata is valid. See here how I do this with Uniswap, but you want to use a Balancer "trusted" factory contract or the address of the vault itself as the check. Then get the pool tokens from the vault. The vault address can be stored as an immutable in this feed factory contract, and passed in to the constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also relevant from audit. Would change to something like:
This way we revert on the
withRegisteredPool()
modifier Balancer has if the passed in pool ID isn't actually a valid pool