Docs: Add example showing how to identify and create symlinks #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushmanchhabra
changed the title
ayushmanchhabra
changed the title
|
@overlookmotel requesting for review, thanks |
|
Actually it doesn't make sense to add this to docs without testing this behaviour...🤔 |
|
I agree it's not a great idea to add this to docs if we're not sure it's correct. However, if you'd like to, would you like to make a PR to the docs to add something along the lines of "Symlinks: Identifying symlinks may be dependent on individual ZIP file implementations. But some investigations into it here..." and link to #39? The work you've done investigating this is really useful, and it'd be nice to be able to point users to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #39
Refs: #44 (comment)
As discussed, I have added an example of handling symlinks. Will try to implement
entry.isSymlinksoon!