Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lb): create guide migration lb #7484

Merged
merged 12 commits into from
Feb 14, 2025
Merged

feat(lb): create guide migration lb #7484

merged 12 commits into from
Feb 14, 2025

Conversation

OvhValentin
Copy link
Contributor

@OvhValentin OvhValentin commented Jan 31, 2025 •
edited
Loading

  • Create guide
  • Add in index

@OvhValentin OvhValentin marked this pull request as draft January 31, 2025 15:54
antonin-a
antonin-a requested changes Feb 7, 2025
View reviewed changes
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md

Here, 224 corresponds to the TTL in seconds (i.e. approximately 4 minutes). This means that the DNS servers keep this IP in cache for this length of time before checking for an update.

### Lower the TTL before migration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the guide it is important to lower the TTL duration before applying the LB change (section juste above). We should move this section at the beginning of the guide ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed with this alert: 59de87f

...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
antonin-a
antonin-a reviewed Feb 11, 2025
View reviewed changes
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
@Lucasgranet Lucasgranet self-requested a review February 12, 2025 09:03
cortexx
cortexx requested changes Feb 12, 2025
View reviewed changes
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
@cortexx
Copy link
Contributor

cortexx commented Feb 12, 2025 •
edited by OvhValentin
Loading

Hello,
It is maybe out the scope of this PR but could you rename the expose_your_applications_using_a_load_balancer folder by replacing underscore by hyphen to stay consistent with the codebase : expose-your-applications-using-a-load-balancer.
Thanks :)

@OvhValentin
Copy link
Contributor Author

Hello, It is maybe out the scope of this PR but could you rename the expose_your_applications_using_a_load_balancer folder by replacing underscore by hyphen to stay consistent with the codebase : expose-your-applications-using-a-load-balancer. Thanks :)

Hello, this is indeed out of scope ( of this PR, which is for the creation of the LB mirgation guide )and would lead to change several docs to redirect to the new folder name.

cortexx
cortexx requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@cortexx cortexx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor typos to fix before merge ^^
Thanks :)
-- Joël

...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Show resolved Hide resolved
@Lucasgranet
Copy link
Member

Thank you @OvhValentin

@cortexx
Copy link
Contributor

cortexx commented Feb 13, 2025

Indeed, as already said by @Lucasgranet, thanks for your work 👍

@OvhValentin OvhValentin marked this pull request as ready for review February 14, 2025 08:52
Y0Coss
Y0Coss reviewed Feb 14, 2025
View reviewed changes
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
...tainers_orchestration/managed_kubernetes/migrate-loadbalancer-iolb-to-octavia/guide.en-gb.md Outdated Show resolved Hide resolved
@Y0Coss Y0Coss merged commit 7384d47 into develop Feb 14, 2025
@Y0Coss Y0Coss deleted the feat-create-guide-migrate-lb branch February 14, 2025 11:24
@Y0Coss
Copy link
Collaborator

Y0Coss commented Feb 14, 2025

Thank you for your contribution @OvhValentin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Y0Coss Y0Coss Y0Coss left review comments

@cortexx cortexx cortexx approved these changes

@antonin-a antonin-a antonin-a approved these changes

@Lucasgranet Lucasgranet Lucasgranet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OvhValentin @cortexx @Lucasgranet @Y0Coss @antonin-a