refactor(zimbra): tests & improve test coverage

Signed-off-by: Tristan WAGNER <[email protected]>
ovh · Oct 11, 2024 · 1a078d8 · 1a078d8
1 parent a4d4d15
commit 1a078d8
Show file tree

Hide file tree

Showing 67 changed files with 1,086 additions and 1,420 deletions.
diff --git a/packages/manager/apps/zimbra/.gitignore b/packages/manager/apps/zimbra/.gitignore
@@ -0,0 +1 @@
+coverage
diff --git a/packages/manager/apps/zimbra/src/api/_mock_/account.ts b/packages/manager/apps/zimbra/src/api/_mock_/account.ts
@@ -1,82 +1,94 @@
 import { AccountType } from '@/api/account';
 import { ResourceStatus } from '@/api/api.type';
 
-export const accountMock: AccountType[] = [
-  {
-    checksum: 'string',
-    currentState: {
-      contactInformation: {
-        city: 'string',
-        company: 'string',
-        country: 'string',
-        faxNumber: 'string',
-        mobileNumber: 'string',
-        office: 'string',
-        phoneNumber: 'string',
-        postcode: 'string',
-        profession: 'string',
-        service: 'string',
-        street: 'string',
-      },
-      createdAt: '2024-07-09T13:27:12.775Z',
-      description: 'string',
-      detailedStatus: [
-        {
-          details: 'string',
-          link: 'string',
-          status: 'BLOCKEDFORSPAM',
-        },
-      ],
-      displayName: 'string',
-      domainId: '19097ad4-2870-4000-8bb0-470f414b0301',
-      email: 'string',
-      firstName: 'string',
-      hideInGal: false,
-      lastConnectionAt: '2024-07-09T13:27:12.775Z',
-      lastName: 'string',
-      offer: 'BUSINESS',
-      organizationId: '19097ad4-2870-4000-82b3-b71a147bc580',
-      organizationLabel: 'string',
-      quota: {
-        available: 0,
-        used: 0,
-      },
-      updatedAt: '2024-07-09T13:27:12.775Z',
+export const accountDetailMock: AccountType = {
+  checksum: 'string',
+  currentState: {
+    contactInformation: {
+      city: 'string',
+      company: 'string',
+      country: 'string',
+      faxNumber: 'string',
+      mobileNumber: 'string',
+      office: 'string',
+      phoneNumber: 'string',
+      postcode: 'string',
+      profession: 'string',
+      service: 'string',
+      street: 'string',
     },
-    currentTasks: [
+    createdAt: '2024-07-09T13:27:12.775Z',
+    description: 'string',
+    detailedStatus: [
       {
-        id: '19097ad4-2870-4000-8bed-ecab3a061780',
+        details: 'string',
         link: 'string',
-        status: 'ERROR',
-        type: 'string',
+        status: 'BLOCKEDFORSPAM',
       },
     ],
-    id: '19097ad4-2880-4000-8b03-9d110f0b8f80',
-    resourceStatus: ResourceStatus.CREATING,
-    targetSpec: {
-      contactInformation: {
-        city: 'string',
-        company: 'string',
-        country: 'string',
-        faxNumber: 'string',
-        mobileNumber: 'string',
-        office: 'string',
-        phoneNumber: 'string',
-        postcode: 'string',
-        profession: 'string',
-        service: 'string',
-        street: 'string',
-      },
-      description: 'string',
-      displayName: 'string',
-      email: 'string',
-      firstName: 'string',
-      hideInGal: false,
-      lastName: 'string',
-      quota: {
-        available: 0,
-        used: 0,
-      },
+    displayName: 'string',
+    domainId: '19097ad4-2870-4000-8bb0-470f414b0301',
+    email: 'string',
+    firstName: 'string',
+    hideInGal: false,
+    lastConnectionAt: '2024-07-09T13:27:12.775Z',
+    lastName: 'string',
+    offer: 'BUSINESS',
+    organizationId: '19097ad4-2870-4000-82b3-b71a147bc580',
+    organizationLabel: 'string',
+    quota: {
+      available: 0,
+      used: 0,
+    },
+    updatedAt: '2024-07-09T13:27:12.775Z',
+  },
+  currentTasks: [
+    {
+      id: '19097ad4-2870-4000-8bed-ecab3a061780',
+      link: 'string',
+      status: 'ERROR',
+      type: 'string',
     },
+  ],
+  id: '19097ad4-2880-4000-8b03-9d110f0b8f80',
+  resourceStatus: ResourceStatus.READY,
+  targetSpec: {
+    contactInformation: {
+      city: 'string',
+      company: 'string',
+      country: 'string',
+      faxNumber: 'string',
+      mobileNumber: 'string',
+      office: 'string',
+      phoneNumber: 'string',
+      postcode: 'string',
+      profession: 'string',
+      service: 'string',
+      street: 'string',
+    },
+    description: 'string',
+    displayName: 'string',
+    email: 'string',
+    firstName: 'string',
+    hideInGal: false,
+    lastName: 'string',
+    quota: {
+      available: 0,
+      used: 0,
+    },
+  },
+};
+
+export const accountsMock: AccountType[] = [
+  accountDetailMock,
+  {
+    ...accountDetailMock,
+    id: '19097ad4-2880-4444-8b03-9d110f0b8f80',
+    resourceStatus: ResourceStatus.CREATING,
+  },
+  {
+    ...accountDetailMock,
+    id: '19097ad4-2880-5555-8b03-9d110f0b8f80',
+    resourceStatus: ResourceStatus.ERROR,
   },
 ];
diff --git a/packages/manager/apps/zimbra/src/api/_mock_/domain.ts b/packages/manager/apps/zimbra/src/api/_mock_/domain.ts
@@ -1,44 +1,46 @@
 import { DomainType } from '@/api/domain';
 import { ResourceStatus } from '@/api/api.type';
 
-export const domainMock: DomainType[] = [
-  {
-    id: '3fa85f64-5717-4562-b3fc-2c963f66afa6',
-    resourceStatus: ResourceStatus.READY,
-    checksum: 'string',
-    targetSpec: {
-      organizationId: '00000000-0000-0000-0000-000000000000',
-    },
-    currentState: {
-      organizationId: '00000000-0000-0000-0000-000000000000',
-      name: 'NormalDomain',
-      status: 'READY',
-      createdAt: '2024-04-12T12:27:47.213Z',
-      updatedAt: '2024-04-12T12:27:47.213Z',
-      organizationLabel: 'ToyStory',
-      cnameToCheck: '',
-      accountsStatistics: [
-        {
-          offer: 'STARTER',
-          configuredAccountsCount: 0,
-          availableAccountsCount: 4,
-        },
-      ],
-      expectedDNSConfig: {
-        mx: [],
-        ownership: {
-          cname: null,
-        },
-      },
-    },
-    currentTasks: [
+export const domainDetailMock: DomainType = {
+  id: '3fa85f64-5717-4562-b3fc-2c963f66afa6',
+  resourceStatus: ResourceStatus.READY,
+  checksum: 'string',
+  targetSpec: {
+    organizationId: '00000000-0000-0000-0000-000000000000',
+  },
+  currentState: {
+    organizationId: '00000000-0000-0000-0000-000000000000',
+    name: 'NormalDomain',
+    status: 'READY',
+    createdAt: '2024-04-12T12:27:47.213Z',
+    updatedAt: '2024-04-12T12:27:47.213Z',
+    organizationLabel: 'ToyStory',
+    cnameToCheck: '',
+    accountsStatistics: [
       {
-        id: '3fa85f64-5717-4562-b3fc-2c963f66afa6',
-        type: 'string',
-        link: 'string',
+        offer: 'STARTER',
+        configuredAccountsCount: 0,
+        availableAccountsCount: 4,
       },
     ],
+    expectedDNSConfig: {
+      mx: [],
+      ownership: {
+        cname: null,
+      },
+    },
   },
+  currentTasks: [
+    {
+      id: '3fa85f64-5717-4562-b3fc-2c963f66afa6',
+      type: 'string',
+      link: 'string',
+    },
+  ],
+};
+
+export const domainsMock: DomainType[] = [
+  domainDetailMock,
   {
     id: '3fa91f64-0000-4562-b3fc-000000000000',
     resourceStatus: ResourceStatus.READY,

diff --git a/packages/manager/apps/zimbra/src/api/_mock_/index.ts b/packages/manager/apps/zimbra/src/api/_mock_/index.ts
@@ -4,3 +4,4 @@ export * from './organization';
 export * from './domain';
 export * from './account';
 export * from './alias';
+export * from './task';
diff --git a/packages/manager/apps/zimbra/src/api/_mock_/task.ts b/packages/manager/apps/zimbra/src/api/_mock_/task.ts
@@ -0,0 +1,21 @@
+export const taskDetailMock = {
+  createdAt: 'string',
+  errors: [{ message: 'string' }],
+  finishedAt: 'string',
+  id: '1',
+  link: 'string',
+  message: 'string',
+  progress: [{ name: 'string', status: 'string' }],
+  startedAt: 'string',
+  status: 'string',
+  type: 'string',
+  updatedAt: 'string',
+};
+
+export const taskMocks = [
+  taskDetailMock,
+  { ...taskDetailMock, id: '2' },
+  { ...taskDetailMock, id: '3' },
+  { ...taskDetailMock, id: '4' },
+  { ...taskDetailMock, id: '5' },
+];
diff --git a/packages/manager/apps/zimbra/src/components/Breadcrumb/Breadcrumb.tsx b/packages/manager/apps/zimbra/src/components/Breadcrumb/Breadcrumb.tsx
@@ -55,7 +55,13 @@ export const Breadcrumb: React.FC<BreadcrumbProps> = ({
     ...items,
   ].filter(Boolean);
 
-  return <OsdsBreadcrumb className="mb-4" items={breadcrumbItems} />;
+  return (
+    <OsdsBreadcrumb
+      data-testid="breadcrumb"
+      className="mb-4"
+      items={breadcrumbItems}
+    />
+  );
 };
 
 export default Breadcrumb;
diff --git a/packages/manager/apps/zimbra/src/components/Breadcrumb/__test__/Breadcrumb.spec.tsx b/packages/manager/apps/zimbra/src/components/Breadcrumb/__test__/Breadcrumb.spec.tsx
@@ -0,0 +1,12 @@
+import React from 'react';
+import { describe, expect } from 'vitest';
+import { render } from '@/utils/test.provider';
+import Breadcrumb from '../Breadcrumb';
+
+describe('Breadcrumb component', () => {
+  it('should render', async () => {
+    const { getByTestId } = render(<Breadcrumb />);
+    const cmp = getByTestId('breadcrumb');
+    expect(cmp).toBeInTheDocument();
+  });
+});
diff --git a/packages/manager/apps/zimbra/src/components/ButtonTooltip/ButtonTooltip.tsx b/packages/manager/apps/zimbra/src/components/ButtonTooltip/ButtonTooltip.tsx
@@ -52,6 +52,7 @@ const ButtonTooltip: React.FC<ButtonTooltipProps> = (props) => {
         variant={ODS_BUTTON_VARIANT.stroked}
         color={ODS_THEME_COLOR_INTENT.primary}
         onClick={(event) => handleTooltipToggle(event)}
+        data-testid="button-tooltip"
         circle
       >
         <OsdsIcon

diff --git a/packages/manager/apps/zimbra/src/components/ButtonTooltip/__test__/ButtonTooltip.spec.tsx b/packages/manager/apps/zimbra/src/components/ButtonTooltip/__test__/ButtonTooltip.spec.tsx
@@ -0,0 +1,14 @@
+import React from 'react';
+import { describe, expect } from 'vitest';
+import { render } from '@/utils/test.provider';
+import ButtonTooltip from '../ButtonTooltip';
+
+describe('ButtonTooltip component', () => {
+  it('should render', async () => {
+    const { getByTestId } = render(
+      <ButtonTooltip tooltipContent={[{ label: 'Test' }]} />,
+    );
+    const cmp = getByTestId('button-tooltip');
+    expect(cmp).toBeInTheDocument();
+  });
+});
diff --git a/packages/manager/apps/zimbra/src/components/Error/__test__/Error.spec.tsx b/packages/manager/apps/zimbra/src/components/Error/__test__/Error.spec.tsx
@@ -0,0 +1,29 @@
+import React from 'react';
+import { describe, expect, vi } from 'vitest';
+import { render } from '@/utils/test.provider';
+import ErrorBanner from '../Error';
+
+vi.mock('@ovh-ux/manager-react-core-application', async (importActual) => {
+  return {
+    ...(await importActual<
+      typeof import('@ovh-ux/manager-react-core-application')
+    >()),
+    useShell: vi.fn(() => ({
+      tracking: {
+        trackPage: vi.fn(),
+      },
+      environment: {
+        getEnvironment: vi.fn(() => Promise.resolve({})),
+      },
+    })),
+  };
+});
+
+describe('Error component', () => {
+  it('should render', async () => {
+    const { getByText } = render(
+      <ErrorBanner error={{ data: { message: 'test' } }} />,
+    );
+    expect(getByText('test')).toBeInTheDocument();
+  });
+});
diff --git a/packages/manager/apps/zimbra/src/components/Loading/Loading.tsx b/packages/manager/apps/zimbra/src/components/Loading/Loading.tsx
@@ -8,7 +8,7 @@ export default function Loading({
   size = ODS_SPINNER_SIZE.md,
 }) {
   return (
-    <div className={className}>
+    <div data-testid="spinner" className={className}>
       <OsdsSpinner mode={mode} size={size} inline></OsdsSpinner>
     </div>
   );

diff --git a/packages/manager/apps/zimbra/src/components/Modals/Modal.tsx b/packages/manager/apps/zimbra/src/components/Modals/Modal.tsx
@@ -1,11 +1,8 @@
 import React from 'react';
-import {
-  OsdsButton,
-  OsdsModal,
-  OsdsSpinner,
-} from '@ovhcloud/ods-components/react';
+import { OsdsButton, OsdsModal } from '@ovhcloud/ods-components/react';
 import { ODS_THEME_COLOR_INTENT } from '@ovhcloud/ods-common-theming';
-import { ODS_BUTTON_VARIANT, ODS_SPINNER_MODE } from '@ovhcloud/ods-components';
+import { ODS_BUTTON_VARIANT } from '@ovhcloud/ods-components';
+import Loading from '@/components/Loading/Loading';
 
 export interface ButtonType {
   testid?: string;
@@ -47,14 +44,7 @@ const Modal: React.FC<ModalProps> = ({
       onOdsModalClose={onDismissible}
     >
       {!isLoading && <div className="flex flex-col text-left">{children}</div>}
-      {isLoading && (
-        <div className="flex flex-col text-left">
-          <OsdsSpinner
-            mode={ODS_SPINNER_MODE.indeterminate}
-            inline
-          ></OsdsSpinner>
-        </div>
-      )}
+      {isLoading && <Loading />}
 
       {secondaryButton && (
         <OsdsButton