-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iam): added applications page #13065
Conversation
Signed-off-by: Daniel Fiala <[email protected]>
feat(iam): added applications page
packages/manager/modules/iam/src/dashboard/applications/applications.controller.js
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in https://github.com/ovh/manager/blob/master/CONTRIBUTING.md#translations, developers are only authorised to update in Messages_fr_FR.json
file. So could you please remove the changes in other locale files?
|
Signed-off-by: Daniel Fiala <[email protected]>
019c9f6
to
93c2aa4
Compare
Quality Gate passedIssues Measures |
This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed. |
Bump - Not stale see #13403 |
This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed. |
This Pull Request is now closed due to inactivity. |
develop
Description
Hey there,
I'm using access tokens for some of my devops stuff, like Terraform, etc. It would be really handy to see my applications listed right on the website. So, I decided to implement it on my own and added a new section to IAM dashboard.
This PR adds an "Applications" section to the IAM dashboard. I'm not an OVH developer, so I did my best to follow the coding styles. There seem to be a bunch of different styles, so I went with what looked like the newest one – using custom HTML elements to build the table.
One thing: I couldn't find any pagination support for the
/me/api/application
endpoint, so it's not included right now. Maybe that can be added later. Also, you can easily delete an application through the action menu. I figured there might be more context actions there in the future, like viewing credentials and stuff.Related
PS: I've opened another pull request, but I somehow misread the line in CONTRIBUTING.md stating that these changes should be merged into
develop
.