Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iam): added applications page #13065

Closed
wants to merge 3 commits into from

Conversation

zZHorizonZz
Copy link
Contributor

@zZHorizonZz zZHorizonZz commented Sep 12, 2024

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally ( I tried linting the whole project but there are errors from completely unrelated packages)
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Hey there,

I'm using access tokens for some of my devops stuff, like Terraform, etc. It would be really handy to see my applications listed right on the website. So, I decided to implement it on my own and added a new section to IAM dashboard.

This PR adds an "Applications" section to the IAM dashboard. I'm not an OVH developer, so I did my best to follow the coding styles. There seem to be a bunch of different styles, so I went with what looked like the newest one – using custom HTML elements to build the table.

One thing: I couldn't find any pagination support for the /me/api/application endpoint, so it's not included right now. Maybe that can be added later. Also, you can easily delete an application through the action menu. I figured there might be more context actions there in the future, like viewing credentials and stuff.

image
image

Related

PS: I've opened another pull request, but I somehow misread the line in CONTRIBUTING.md stating that these changes should be merged into develop.

Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in https://github.com/ovh/manager/blob/master/CONTRIBUTING.md#translations, developers are only authorised to update in Messages_fr_FR.json file. So could you please remove the changes in other locale files?

@zZHorizonZz
Copy link
Contributor Author

zZHorizonZz commented Sep 16, 2024

As mentioned in https://github.com/ovh/manager/blob/master/CONTRIBUTING.md#translations, developers are only authorised to update in Messages_fr_FR.json file. So could you please remove the changes in other locale files?

Is it okay if I put an English translation into the files even though it's a French translation file? I don't really know French, and I don't think google translate will do a good job with this.

Copy link

Copy link
Contributor

This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed.

@github-actions github-actions bot added the stale No activity since a long time label Oct 18, 2024
@zZHorizonZz
Copy link
Contributor Author

Bump - Not stale see #13403

@github-actions github-actions bot removed the stale No activity since a long time label Oct 30, 2024
Copy link
Contributor

This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed.

@github-actions github-actions bot added the stale No activity since a long time label Nov 29, 2024
Copy link
Contributor

This Pull Request is now closed due to inactivity.

@github-actions github-actions bot closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature stale No activity since a long time translation required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants