Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dedicated.pcc): fix VCD translation in services column #13550

Merged
merged 1 commit into from
Oct 11, 2024
Merged

feat(dedicated.pcc): fix VCD translation in services column #13550

merged 1 commit into from
Oct 11, 2024

Conversation

pauldkn
Copy link
Contributor

@pauldkn pauldkn commented Oct 10, 2024

ref: MANAGER-15455

Question Answer
Branch? feat/hpc-vcd-beta
Bug fix? yes
New feature? no
Breaking change? no
Tickets fix/MANAGER-15455
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

feat(dedicated.pcc): update VCD translation in services column
88b1c8b 
  ref: MANAGER-15455

Signed-off-by: Paul Dickerson <[email protected]>
@pauldkn pauldkn requested a review from a team as a code owner October 10, 2024 14:32
@pauldkn pauldkn requested review from antonymarion, darsene and mhelhali-soufien and removed request for a team October 10, 2024 14:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pauldkn pauldkn merged commit 60a5e71 into feat/hpc-vcd-beta Oct 11, 2024
14 checks passed
@pauldkn pauldkn deleted the fix/MANAGER-15455 branch October 11, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darsene darsene darsene approved these changes

@chipp972 chipp972 chipp972 approved these changes

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pauldkn @chipp972 @darsene