feat(procedures): implemented gdpr form #13558
Conversation
oalkabouss
requested review from
sidlynx,
frenautvh,
qpavy,
sachinrameshn and
JacquesLarique
and removed request for
a team
oalkabouss
force-pushed
the
feat/MANAGER-15317
branch
from
d8bbf5a to
0d3f6cb
Compare
github-actions
bot
added
the
has conflicts
oalkabouss
force-pushed
the
feat/MANAGER-15317
branch
from
0d3f6cb to
4598d61
Compare
github-actions
bot
removed
the
has conflicts
There was a problem hiding this comment.
You shouldn't be modifying this file on this project
There was a problem hiding this comment.
I added it to do the test in QA.
There was a problem hiding this comment.
This should have no impact on the procedures application (as it is not displayed inside the container, and has no dependency to it)
There was a problem hiding this comment.
Do you plan to use this in multiple places ?
If not, I'm not sure it is relevant to create a dedicated component
There was a problem hiding this comment.
Not now. I added it in case it might be useful on another page in the future. Indeed, it adds extra components... I will delete it.
There was a problem hiding this comment.
Same as #13558 (comment)
| } | ||
| }, [email]); | ||
|
|
||
| console.log(isSubmitting); |
There was a problem hiding this comment.
This console log can be cleaned I think
| vi.mock('react-i18next', () => ({ | ||
| useTranslation: () => ({ | ||
| t: (key: string) => key, | ||
| }), | ||
| })); |
There was a problem hiding this comment.
This is unnecessary, it is already done in setupTests.ts
There was a problem hiding this comment.
Is there any reason for splitting this from the SelectInput component ?
It seems to unnecessarily split the form logic in multiple parts, unless I'm missing qsomething,
The comment #13558 (comment) also apply here
There was a problem hiding this comment.
Same as #13558 (comment)
There was a problem hiding this comment.
Same as #13558 (comment)
oalkabouss
force-pushed
the
feat/MANAGER-15317
branch
from
60e1515 to
e933284
Compare
| 'other_request', | ||
| ]; | ||
|
|
||
| export const EmailRegex = /^[a-zA-Z0-9!#$%&'*+/=?^_`{|}~-]+(?:\.[a-zA-Z0-9!#$%&'*+/=?^_`{|}~-]+)*@(?:[a-zA-Z0-9](?:[a-zA-Z0-9-]*[a-zA-Z0-9])?\.)+[a-zA-Z0-9]{2}(?:[a-zA-Z0-9-]*[a-zA-Z0-9])?$/; |
There was a problem hiding this comment.
Are you sure for that regex ? I never see numbers in the tld part
There was a problem hiding this comment.
yep, i used Xander regex
oalkabouss
force-pushed
the
feat/MANAGER-15317
branch
from
e933284 to
b258ba2
Compare
ref:MANAGER-15317 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
oalkabouss
force-pushed
the
feat/MANAGER-15317
branch
from
b258ba2 to
14e3e07
Compare
ref:MANAGER-15317 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
oalkabouss
force-pushed
the
feat/MANAGER-15317
branch
from
14e3e07 to
a8537ec
Compare
|
ref:MANAGER-15317 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
ref:MANAGER-15317 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
ref:MANAGER-15317 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
ref:MANAGER-15317
feat/MANAGER-15315Description
Related