Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(billing): init the application #13631

Merged
merged 3 commits into from
Dec 5, 2024
Merged

feat(billing): init the application #13631

merged 3 commits into from
Dec 5, 2024

Conversation

MaximeBajeux
Copy link
Contributor

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15024
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@MaximeBajeux MaximeBajeux requested a review from a team as a code owner October 17, 2024 07:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

oalkabouss
oalkabouss previously approved these changes Oct 17, 2024
View reviewed changes
JacquesLarique
JacquesLarique previously approved these changes Oct 17, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed.

@github-actions github-actions bot added the stale No activity since a long time label Nov 17, 2024
@github-actions github-actions bot removed the stale No activity since a long time label Nov 26, 2024
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-15024bis branch from 7e0fd8a to 65585a6 Compare December 4, 2024 17:22
@MaximeBajeux MaximeBajeux requested review from a team as code owners December 5, 2024 09:05
JacquesLarique
JacquesLarique previously approved these changes Dec 5, 2024
View reviewed changes
oalkabouss
oalkabouss previously approved these changes Dec 5, 2024
View reviewed changes
@MaximeBajeux MaximeBajeux changed the base branch from master to release/billing-shadow-prod December 5, 2024 13:01
@MaximeBajeux MaximeBajeux changed the base branch from release/billing-shadow-prod to release/shadow-prod-billing December 5, 2024 13:13
Maxime Bajeux and others added 3 commits December 5, 2024 14:17
feat(billing): init the application
2cfa885 
Signed-off-by: Maxime Bajeux <[email protected]>
@MaximeBajeux
feat(billing): move the code to the new app (#14386)
c651cef 
ref: MANAGER-15025
Signed-off-by: Maxime Bajeux <[email protected]>
@MaximeBajeux
fix(billing): fix shadow prod issues (#14439)
3c63ad0 
ref: MANAGER-14917
Signed-off-by: Maxime Bajeux <[email protected]>
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-15024bis branch from 23363e4 to 3c63ad0 Compare December 5, 2024 13:18
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024 •
edited
Loading

Quality Gate Failed Quality Gate failed

Failed conditions
6 Security Hotspots
16.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@MaximeBajeux MaximeBajeux merged commit 3fcb4d9 into release/shadow-prod-billing Dec 5, 2024
14 of 16 checks passed
@MaximeBajeux MaximeBajeux deleted the feat/MANAGER-15024bis branch December 5, 2024 13:37
JacquesLarique pushed a commit that referenced this pull request Dec 9, 2024
@MaximeBajeux
feat(billing): micro app billing (#13631)
c6f2df9 
ref: MANAGER-14917
Signed-off-by: Maxime Bajeux <[email protected]>
JacquesLarique pushed a commit that referenced this pull request Dec 9, 2024
@MaximeBajeux @JacquesLarique
feat(billing): micro app billing (#13631)
10765a6 
ref: MANAGER-14917
Signed-off-by: Maxime Bajeux <[email protected]>
qpavy pushed a commit that referenced this pull request Dec 10, 2024
@MaximeBajeux
feat(billing): micro app billing (#13631)
72c14b4 
ref: MANAGER-14917
Signed-off-by: Maxime Bajeux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@oalkabouss oalkabouss oalkabouss approved these changes

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti was automatically assigned from ovh/team-manager-dev-angularjs

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
common container feature New feature universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximeBajeux @oalkabouss @JacquesLarique