Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kube): add savings plan banner #13708

Merged
merged 2 commits into from
Jan 3, 2025
Merged

feat(kube): add savings plan banner #13708

merged 2 commits into from
Jan 3, 2025

Conversation

lionel95200x
Copy link
Contributor

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? yes/no
Tickets Fix #TAPC-1911
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Add savings plan banner on kubernetes

Related

@lionel95200x lionel95200x requested review from a team as code owners October 21, 2024 15:19
fredericvilcot
fredericvilcot previously approved these changes Oct 21, 2024
View reviewed changes
feat: add savings plan banner for kubernetes
ae7c26c 
ref: TAPC-1911

Signed-off-by: Lionel Bueno <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anooparveti anooparveti changed the base branch from develop to release/public-cloud-w1 January 3, 2025 08:02
@anooparveti anooparveti merged commit 4b17307 into release/public-cloud-w1 Jan 3, 2025
17 of 19 checks passed
@anooparveti anooparveti deleted the feat/TAPC-1911 branch January 3, 2025 08:03
@anooparveti anooparveti mentioned this pull request Jan 3, 2025
Merged
8 tasks
anooparveti pushed a commit that referenced this pull request Jan 7, 2025
@lionel95200x @ovh-cds @anooparveti
feat(pci-kubernetes): add savings plan banner (#13708)
1eb0a78 
ref: TAPC-1911

Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
@ppprevost ppprevost mentioned this pull request Jan 8, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti approved these changes

@fredericvilcot fredericvilcot fredericvilcot left review comments

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene was automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lionel95200x @anooparveti @fredericvilcot @acavalloni