Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pci-load-balancer): some refactor and trans folders rename #13718

Merged
merged 1 commit into from
Oct 22, 2024
Merged

refactor(pci-load-balancer): some refactor and trans folders rename #13718

merged 1 commit into from
Oct 22, 2024

Conversation

seven-amid
Copy link
Contributor

  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@seven-amid seven-amid requested review from a team as code owners October 22, 2024 09:13
@seven-amid seven-amid requested review from kqesar, frenautvh, qpavy, MaximeBajeux and sachinrameshn and removed request for a team October 22, 2024 09:13
@github-actions github-actions bot added translation required bug Something isn't working labels Oct 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarCloud

@seven-amid seven-amid merged commit 06ae556 into feat/pci-load-balancer Oct 22, 2024
13 of 14 checks passed
@seven-amid seven-amid deleted the fix/some-refactor branch October 22, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqesar kqesar kqesar approved these changes

@sidlynx sidlynx sidlynx approved these changes

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seven-amid @sidlynx @kqesar