Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(procedures): gdpr fix wording & api call with mock #13801

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix(procedures): gdpr fix wording & api call with mock #13801

merged 1 commit into from
Oct 30, 2024

Conversation

oalkabouss
Copy link
Contributor

ref: MANAGER-15368

Question Answer
Branch? feat/procedures-gdpr
Bug fix? yes
New feature? no
Breaking change? no
Tickets MANAGER-15368
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@oalkabouss oalkabouss requested review from a team as code owners October 28, 2024 08:06
@oalkabouss oalkabouss requested review from sidlynx, seven-amid, tibs245, sachinrameshn and JacquesLarique and removed request for a team October 28, 2024 08:06
@github-actions github-actions bot added translation required bug Something isn't working labels Oct 28, 2024
@oalkabouss oalkabouss force-pushed the feat/procedures-gdpr branch from 98fb4e6 to 12047a9 Compare October 28, 2024 10:37
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 28, 2024
fix(procedures): gdpr fix wording & api call with mock
e09b685 
ref: MANAGER-15368

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@oalkabouss oalkabouss merged commit 48ce303 into feat/procedures-gdpr Oct 30, 2024
13 checks passed
@oalkabouss oalkabouss deleted the fix/MANAGER-15368 branch October 30, 2024 11:12
oalkabouss added a commit that referenced this pull request Nov 26, 2024
@oalkabouss
fix(procedures): gdpr fix wording & api call with mock (#13801)
94d3f8e 
ref: MANAGER-15368

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
oalkabouss added a commit that referenced this pull request Dec 6, 2024
@oalkabouss
fix(procedures): gdpr fix wording & api call with mock (#13801)
b06acc5 
ref: MANAGER-15368

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stif59100 stif59100 stif59100 approved these changes

@MaximeBajeux MaximeBajeux MaximeBajeux approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 was automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oalkabouss @MaximeBajeux @stif59100