Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(container): animation improvement & add skeleton on entry menu #13867

Merged
merged 1 commit into from
Dec 20, 2024
Merged

feat(container): animation improvement & add skeleton on entry menu #13867

merged 1 commit into from
Dec 20, 2024

Conversation

oalkabouss
Copy link
Contributor

ref: MANAGER-14921

Question Answer
Branch? feat/MANAGER-14461
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@oalkabouss oalkabouss requested review from a team as code owners October 31, 2024 07:43
@oalkabouss oalkabouss requested review from kqesar, frenautvh, qpavy, ghyenne and darsene and removed request for a team October 31, 2024 07:43
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

SimonChaumet
SimonChaumet reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@SimonChaumet SimonChaumet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe check formatter

@SimonChaumet SimonChaumet self-requested a review November 6, 2024 09:35
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 17, 2024
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-14461 branch 2 times, most recently from 7271c21 to 3957f33 Compare December 17, 2024 15:52
feat(container): animation improvement & add skeleton on entry menu
c35aece 
ref: MANAGER-14921

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 20, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MaximeBajeux MaximeBajeux merged commit d218477 into feat/MANAGER-14461 Dec 20, 2024
14 checks passed
@MaximeBajeux MaximeBajeux deleted the feat/MANAGER-14921 branch December 20, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@MaximeBajeux MaximeBajeux MaximeBajeux approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@SimonChaumet SimonChaumet Awaiting requested review from SimonChaumet

Assignees
No one assigned
Labels
container feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oalkabouss @SimonChaumet @MaximeBajeux @JacquesLarique