feat(dedicated): add iplb delete option for us #14243

mhelhali-soufien · 2024-11-25T07:41:42Z

Question	Answer
Branch?	`master` / `release/**` / `develop`
Bug fix?	yes/no
New feature?	yes/no
Breaking change?	yes/no
Tickets	Fix #MANAGER-15666
License	BSD 3-Clause

Try to keep pull requests small so they can be easily reviewed.
Commits are signed-off
Only FR translations have been updated
Branch is up-to-date with target branch
Lint has passed locally
Standalone app was ran and tested locally
Ticket reference is mentioned in linked commits (internal only)
Breaking change is mentioned in relevant commits

Description

+  "iplb_terminate_service_success": "Votre demande de suppression de votre service a été prise en compte. Un e-mail contenant la procédure vous a été envoyé.",
+  "iplb_terminate_service_error": "Une erreur est survenue lors de la demande de suppression de votre service. {{error}}",
+  "iplb_terminate_service_confirm_input": "Entrez \"TERMINATE\" dans le champ ci-dessous pour confirmer",
+  "iplb_terminate_service_terminate_valide": "Valider",


Suggested change

"iplb_terminate_service_terminate_valide": "Valider",

"iplb_terminate_service_terminate_valid": "Valider",

sachinrameshn · 2024-11-26T10:04:00Z

packages/manager/modules/iplb/src/listing/listing.route.js

    },
-    redirectTo: (transition) =>


Why are we removing this redirection for empty case ?

sachinrameshn · 2024-11-26T10:15:04Z

packages/manager/modules/iplb/src/modal/terminate/terminate.controller.js

+    this.$http = $http;
+    this.Alerter = Alerter;
+  }
+


Suggested change

$onInit() {

this.isDeleting = false;

}

packages/manager/modules/iplb/src/iplb.module.js

packages/manager/modules/iplb/src/home/iplb-home.controller.js

packages/manager/modules/iplb/src/listing/listing.controller.js

sachinrameshn · 2024-11-29T09:34:49Z

packages/manager/modules/iplb/src/listing/listing.controller.js

+
+  $onInit() {
+    super.$onInit();
+    console.log(this.Alerter);


Suggested change

console.log(this.Alerter);

sachinrameshn · 2024-11-29T09:38:03Z

packages/manager/modules/iplb/src/listing/listing.html

+    <oui-action-menu
+        data-compact
+        data-placement="end"
+        data-ng-if="$ctrl.isDeleteOptionsAvailable"
+    >
+        <oui-action-menu-item data-on-click="$ctrl.gotoService($row)">
+            <span data-translate="iplb_listing_action_detail"></span>
+        </oui-action-menu-item>
+        <oui-action-menu-item data-on-click="$ctrl.deleteIplb($row)">
+            <span data-translate="iplb_listing_action_delete"></span>
+        </oui-action-menu-item>
+    </oui-action-menu>


Suggested change

<oui-action-menu

data-compact

data-placement="end"

data-ng-if="$ctrl.isDeleteOptionsAvailable"

>

<oui-action-menu-item data-on-click="$ctrl.gotoService($row)">



</oui-action-menu-item>

<oui-action-menu-item data-on-click="$ctrl.deleteIplb($row)">



</oui-action-menu-item>

</oui-action-menu>

<oui-action-menu

data-compact

data-placement="end"

>

<oui-action-menu-item data-on-click="$ctrl.gotoService($row)">



</oui-action-menu-item>

<oui-action-menu-item data-ng-if="$ctrl.isDeleteOptionsAvailable" data-on-click="$ctrl.deleteIplb($row)">



</oui-action-menu-item>

</oui-action-menu>

Agree with that request, you can keep action menu for the detail action.

sachinrameshn · 2024-11-29T09:38:56Z

packages/manager/modules/iplb/src/modal/terminate/terminate.html

+    data-heading="{{:: 'iplb_terminate_service' | translate}}"
+    data-primary-action="$ctrl.terminate()"
+    data-primary-disabled="!$ctrl.terminateConfirmation"
+    data-primary-label="{{:: 'iplb_terminate_service_terminate_valide' | translate }}"


Suggested change

data-primary-label="{{:: 'iplb_terminate_service_terminate_valide' | translate }}"

data-primary-label="{{:: 'iplb_terminate_service_terminate_valid' | translate }}"

sachinrameshn · 2024-11-29T09:41:43Z

packages/manager/modules/iplb/src/modal/terminate/terminate.controller.js

+  terminate() {
+    this.$http
+      .post(`/ipLoadbalancing/${this.service.serviceName}/terminate`)
+      .then(() => {
+        this.Alerter.success(
+          this.$translate.instant('iplb_terminate_service_success'),
+        );
+      })
+      .catch((err) => {
+        this.Alerter.error(
+          this.$translate.instant('iplb_terminate_service_error', {
+            t0: err.data ? err.data.message : err.message,
+          }),
+          this.alertId,
+        );
+      });
+    this.$uibModalInstance.close();
+  }


Suggested change

terminate() {

this.$http

.post(`/ipLoadbalancing/${this.service.serviceName}/terminate`)

.then(() => {

this.Alerter.success(

this.$translate.instant('iplb_terminate_service_success'),

);

})

.catch((err) => {

this.Alerter.error(

this.$translate.instant('iplb_terminate_service_error', {

t0: err.data ? err.data.message : err.message,

}),

this.alertId,

);

});

this.$uibModalInstance.close();

}

terminate() {

this.$http

.post(`/ipLoadbalancing/${this.service.serviceName}/terminate`)

.then(() => {

this.Alerter.success(

this.$translate.instant('iplb_terminate_service_success'),

);

this.$uibModalInstance.close();

})

.catch((err) => {

this.Alerter.error(

this.$translate.instant('iplb_terminate_service_error', {

t0: err.data ? err.data.message : err.message,

}),

this.alertId,

);

this.$uibModalInstance.dismiss();

});

}

sachinrameshn · 2024-11-29T09:43:40Z

packages/manager/modules/iplb/src/listing/listing.controller.js

+  $onInit() {
+    super.$onInit();
+    console.log(this.Alerter);
+    this.Alerter.error('test test test', 'InfoErrors');


Suggested change

this.Alerter.error('test test test', 'InfoErrors');

sachinrameshn · 2024-11-29T09:43:53Z

packages/manager/modules/iplb/src/listing/listing.controller.js

+    this.$state = $state;
+    this.ouiDatagridService = ouiDatagridService;
+    this.CucControllerHelper = CucControllerHelper;
+    this.Alerter = Alerter;


Suggested change

this.Alerter = Alerter;

sachinrameshn · 2024-11-29T09:44:06Z

packages/manager/modules/iplb/src/listing/listing.controller.js

+
+export default class iplbListingCtrl extends ListLayoutHelper.ListLayoutCtrl {
+  /* @ngInject */
+  constructor($state, $q, Alerter, ouiDatagridService, CucControllerHelper) {


Suggested change

constructor($state, $q, Alerter, ouiDatagridService, CucControllerHelper) {

constructor($state, $q, ouiDatagridService, CucControllerHelper) {

sachinrameshn · 2024-11-29T09:45:54Z

packages/manager/modules/iplb/src/listing/constants.js

+export const DEFAULT_NUMBER_OF_COLUMNS = 4;
+
+export const STRING_COLUMN_OPTIONS = [
+  'contains',
+  'startsWith',
+  'endsWith',
+  'is',
+  'isNot',
+];
+
+export const NUMBER_COLUMN_OPTIONS = ['is'];
+export const LB_DELETE_FEATURE = 'ip-load-balancer:delete';
+
+export default {
+  DEFAULT_NUMBER_OF_COLUMNS,
+  NUMBER_COLUMN_OPTIONS,
+  STRING_COLUMN_OPTIONS,
+  LB_DELETE_FEATURE,
+};


To remove

Suggested change

export const DEFAULT_NUMBER_OF_COLUMNS = 4;

export const STRING_COLUMN_OPTIONS = [

'contains',

'startsWith',

'endsWith',

'is',

'isNot',

];

export const NUMBER_COLUMN_OPTIONS = ['is'];

export const LB_DELETE_FEATURE = 'ip-load-balancer:delete';

export default {

DEFAULT_NUMBER_OF_COLUMNS,

NUMBER_COLUMN_OPTIONS,

STRING_COLUMN_OPTIONS,

LB_DELETE_FEATURE,

};

ref: MANAGER-15666 Signed-off-by: soufien mhelhali <[email protected]>

sonarqubecloud · 2024-12-04T09:46:22Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-01-05T00:00:36Z

This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed.

mhelhali-soufien requested a review from a team as a code owner November 25, 2024 07:41

mhelhali-soufien requested review from antonymarion, MaximeBajeux and ghyenne November 25, 2024 07:41

github-actions bot added universe-bare-metal-cloud translation required feature New feature labels Nov 25, 2024

sachinrameshn reviewed Nov 26, 2024

View reviewed changes

sachinrameshn requested changes Nov 26, 2024

View reviewed changes

qpavy requested changes Nov 28, 2024

View reviewed changes

packages/manager/modules/iplb/src/iplb.module.js Show resolved Hide resolved

packages/manager/modules/iplb/src/home/iplb-home.controller.js Show resolved Hide resolved

packages/manager/modules/iplb/src/listing/listing.controller.js Show resolved Hide resolved

sachinrameshn reviewed Nov 29, 2024

View reviewed changes

sachinrameshn requested changes Nov 29, 2024

View reviewed changes

sachinrameshn reviewed Nov 29, 2024

View reviewed changes

soufien mhelhali added 2 commits November 30, 2024 22:52

feat(dedicated): add iplb delete option for us

8aa4fc8

ref: MANAGER-15666 Signed-off-by: soufien mhelhali <[email protected]>

feat(dedicated): use extends for listing controller

daa5403

mhelhali-soufien force-pushed the feat/MANAGER-15666 branch from 5c82114 to daa5403 Compare December 2, 2024 07:04

feat(dedicated): keep detail navigation for EU/CA

3102b5b

sachinrameshn approved these changes Dec 4, 2024

View reviewed changes

qpavy approved these changes Dec 5, 2024

View reviewed changes

github-actions bot added the stale No activity since a long time label Jan 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dedicated): add iplb delete option for us #14243

feat(dedicated): add iplb delete option for us #14243

mhelhali-soufien commented Nov 25, 2024

sachinrameshn Nov 26, 2024

sachinrameshn Nov 26, 2024

sachinrameshn Nov 26, 2024

sachinrameshn Nov 29, 2024

sachinrameshn Nov 29, 2024

qpavy Dec 3, 2024

sachinrameshn Nov 29, 2024

sachinrameshn Nov 29, 2024

sachinrameshn Nov 29, 2024

sachinrameshn Nov 29, 2024

sachinrameshn Nov 29, 2024

sachinrameshn Nov 29, 2024

sonarqubecloud bot commented Dec 4, 2024

github-actions bot commented Jan 5, 2025

	"iplb_terminate_service_terminate_valide": "Valider",
	"iplb_terminate_service_terminate_valid": "Valider",

	data-primary-label="{{:: 'iplb_terminate_service_terminate_valide' \| translate }}"
	data-primary-label="{{:: 'iplb_terminate_service_terminate_valid' \| translate }}"

	constructor($state, $q, Alerter, ouiDatagridService, CucControllerHelper) {
	constructor($state, $q, ouiDatagridService, CucControllerHelper) {

feat(dedicated): add iplb delete option for us #14243

Are you sure you want to change the base?

feat(dedicated): add iplb delete option for us #14243

Conversation

mhelhali-soufien commented Nov 25, 2024

Description

Related

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Dec 4, 2024

Quality Gate passed

github-actions bot commented Jan 5, 2025