Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-object-storage): create user modal #14381

Merged
merged 1 commit into from
Dec 4, 2024
Merged

feat(pci-object-storage): create user modal #14381

merged 1 commit into from
Dec 4, 2024

Conversation

sidlynx
Copy link
Contributor

@sidlynx sidlynx commented Dec 2, 2024

Question Answer
Branch? feat/pci-object-storage
Bug fix? no
New feature? yes
Breaking change? no
Tickets DTCORE-2877
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@sidlynx sidlynx requested review from a team as code owners December 2, 2024 20:01
@sidlynx sidlynx requested review from kqesar, frenautvh, antonymarion, oalkabouss and darsene and removed request for a team December 2, 2024 20:01
@github-actions github-actions bot added translation required dependencies Pull requests that update a dependency file feature New feature labels Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@ovh-ux/manager-react-components UPDATED 1.41.2 1.43.0

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 3, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 4, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.0% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sidlynx sidlynx merged commit 978687b into feat/pci-object-storage Dec 4, 2024
13 of 14 checks passed
@sidlynx sidlynx deleted the feat/DTCORE-2877 branch December 4, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenautvh frenautvh frenautvh left review comments

@kqesar kqesar kqesar approved these changes

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sidlynx @kqesar @frenautvh