Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(billing): move the code to the new app #14386

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

MaximeBajeux
Copy link
Contributor

Question Answer
Branch? master
Bug fix? no
New feature? no
Breaking change? no
Tickets MANAGER-15025
License BSD 3-Clause
  • [] Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

>
<ovh-payment-method-integration
data-on-initialized="$ctrl.onPaymentMethodIntegrationInitialized.bind($ctrl)"
data-on-submit="$ctrl.onPaymentMethodIntegrationSubmit.bind($ctrl)"

Check failure

Code scanning / SonarCloud

OVH keys should not be disclosed High

Make sure this OVH key gets revoked, changed, and removed from the code. See more on SonarQube Cloud
@@ -98,6 +100,7 @@ export default async (containerEl, shellClient) => {

const defaultErrorHandler = /* @ngInject */ ($state) => {
$state.defaultErrorHandler((error) => {
console.log(error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaned

@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-15024bis branch from 7e0fd8a to 65585a6 Compare December 4, 2024 17:22
Maxime Bajeux added 3 commits December 4, 2024 18:23
ref: MANAGER-15025

Signed-off-by: Maxime Bajeux <[email protected]>
ref: MANAGER-15025

Signed-off-by: Maxime Bajeux <[email protected]>
ref: MANAGER-15025

Signed-off-by: Maxime Bajeux <[email protected]>
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 4, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 4, 2024
ref: MANAGER-15025

Signed-off-by: Maxime Bajeux <[email protected]>
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6 Security Hotspots
16.9% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@MaximeBajeux MaximeBajeux merged commit 784e1c8 into feat/MANAGER-15024bis Dec 5, 2024
10 of 14 checks passed
@MaximeBajeux MaximeBajeux deleted the feat/MANAGER-15025 branch December 5, 2024 09:05
MaximeBajeux added a commit that referenced this pull request Dec 5, 2024
ref: MANAGER-15025
Signed-off-by: Maxime Bajeux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants