Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pci-common): fix flashing effect on shapes input component #14416

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(pci-common): fix flashing effect on shapes input component #14416

wants to merge 2 commits into from
+26 −29

Conversation

sidlynx
Copy link
Contributor

@sidlynx sidlynx commented Dec 4, 2024 •
edited
Loading

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets DTCORE-2918
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@sidlynx sidlynx requested review from a team as code owners December 4, 2024 13:41
@sidlynx sidlynx requested review from kqesar and seven-amid December 4, 2024 13:41
@github-actions github-actions bot added the bug Something isn't working label Dec 4, 2024
kqesar
kqesar previously approved these changes Dec 4, 2024
View reviewed changes
@sidlynx sidlynx changed the base branch from develop to master December 5, 2024 08:43
@sidlynx sidlynx dismissed kqesar’s stale review December 5, 2024 08:43

The base branch was changed.

@sidlynx sidlynx requested review from fredericvilcot, frenautvh and a team as code owners December 5, 2024 08:43
@sidlynx sidlynx force-pushed the fix/shapes-input-flash branch from 6b77ec0 to 4343fcd Compare December 5, 2024 09:08
@sidlynx sidlynx requested a review from kqesar December 5, 2024 09:10
frenautvh
frenautvh previously approved these changes Dec 17, 2024
View reviewed changes
@sidlynx sidlynx force-pushed the fix/shapes-input-flash branch from 48f23f7 to 85534e0 Compare December 17, 2024 08:39
@sidlynx sidlynx force-pushed the fix/shapes-input-flash branch from 85534e0 to d5ebc52 Compare December 17, 2024 08:55
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@ovh-ux/ovh-at-internet ADDED - 0.17.0

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenautvh frenautvh frenautvh left review comments

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@fredericvilcot fredericvilcot Awaiting requested review from fredericvilcot fredericvilcot is a code owner

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@kqesar kqesar Awaiting requested review from kqesar

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sidlynx @kqesar @frenautvh