Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pci-common): import styles from manager-pci-common #14472

Merged

Conversation

SimonChaumet
Copy link
Contributor

@SimonChaumet SimonChaumet commented Dec 6, 2024

Question Answer
Branch? release/public-cloud-w50
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #TAPC-2392
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

After publishing pci-common library the css files weren't imported by the javascript files so we need to import it manually in projects or find a way to fix the build of pci-common.

Fixing pci-common would take too much time, while only 3 projects are concerned.

Related

@SimonChaumet SimonChaumet requested review from a team as code owners December 6, 2024 15:11
@SimonChaumet SimonChaumet requested review from kqesar and seven-amid and removed request for a team December 6, 2024 15:12
@github-actions github-actions bot added the bug Something isn't working label Dec 6, 2024
Copy link

sonarqubecloud bot commented Dec 6, 2024

@fredericvilcot fredericvilcot self-assigned this Dec 6, 2024
@fredericvilcot fredericvilcot merged commit f1b2405 into release/public-cloud-w50 Dec 6, 2024
22 checks passed
@fredericvilcot fredericvilcot deleted the fix/import-pci-common-styles branch December 6, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quality check: ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants