Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dedicated): my services tile fix commitment link #14473

Merged
merged 1 commit into from
Dec 6, 2024
Merged

feat(dedicated): my services tile fix commitment link #14473

merged 1 commit into from
Dec 6, 2024

Conversation

oalkabouss
Copy link
Contributor

ref: MANAGER-16274

Question Answer
Branch? feat/my-services-revamp
Bug fix? yes
New feature? no
Breaking change? no
Tickets MANAGER-16274
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

feat(dedicated): my services tile fix commitment link
1e69af5 
ref: MANAGER-16274

Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
@oalkabouss oalkabouss requested a review from a team as a code owner December 6, 2024 15:13
@oalkabouss oalkabouss requested review from qpavy, anooparveti and ghyenne and removed request for a team December 6, 2024 15:13
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@oalkabouss oalkabouss merged commit 72d3741 into feat/my-services-revamp Dec 6, 2024
14 checks passed
@oalkabouss oalkabouss deleted the feat/MANAGER-16274 branch December 6, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@MaximeBajeux MaximeBajeux MaximeBajeux approved these changes

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti was automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
common feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oalkabouss @MaximeBajeux @JacquesLarique