Feat/pci private registry create restriction tapc 584 #14492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppprevost
requested review from
kqesar,
frenautvh,
antonymarion,
sachinrameshn and
JacquesLarique
github-actions
bot
added
translation required
feature
...es/manager/apps/pci-private-registry/public/translations/ip-restrictions/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
...es/manager/apps/pci-private-registry/public/translations/ip-restrictions/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
...es/manager/apps/pci-private-registry/public/translations/ip-restrictions/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
...es/manager/apps/pci-private-registry/public/translations/ip-restrictions/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
...es/manager/apps/pci-private-registry/public/translations/ip-restrictions/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
...es/manager/apps/pci-private-registry/public/translations/ip-restrictions/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
...es/manager/apps/pci-private-registry/public/translations/ip-restrictions/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
ppprevost
force-pushed
the
feat/pci-private-registry_create-restriction_tapc-584
branch
from
f08bf4f to
8bda40a
Compare
github-actions
bot
removed
the
has conflicts
fredericvilcot
force-pushed
the
feat/pci-private-registry_create-restriction_tapc-584
branch
from
015be75 to
796da9a
Compare
packages/manager/apps/pci-private-registry/src/api/data/ip-restrictions.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/api/data/ip-restrictions.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/pages/CIDR/useDatagridColumn.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/pages/CIDR/useDatagridColumn.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/components/CIDR/ButtonsCIDR.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/components/CIDR/ButtonsCIDR.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/components/CIDR/DeleteModal.component.tsx
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/helpers/index.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/api/data/ip-restrictions.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/api/data/ip-restrictions.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/api/data/ip-restrictions.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/api/data/ip-restrictions.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/components/CIDR/CIDR.component.tsx
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/helpers/index.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/helpers/index.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/pages/CIDR/ManageCIDR.page.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/pages/CIDR/useDatagridColumn.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/pages/CIDR/useDatagridColumn.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
has conflicts
Signed-off-by: CDS Translator Agent <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
ppprevost
force-pushed
the
feat/pci-private-registry_create-restriction_tapc-584
branch
from
187efdd to
70e051e
Compare
github-actions
bot
removed
the
has conflicts
| return result; | ||
| } | ||
|
|
||
| export function capitalizeAndJoin(array: string[]) { |
There was a problem hiding this comment.
There are no test associated?
packages/manager/apps/pci-private-registry/src/pages/CIDR/useDatagridColumn.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-registry/src/components/CIDR/DeleteModal.component.tsx
Show resolved
Hide resolved
ref: TAPC-584 Signed-off-by: Pierre-Philippe <[email protected]>
|
SimonChaumet
approved these changes
Dec 17, 2024
| import AllCheckboxComponent from '@/components/CIDR/AllCheckbox.component'; | ||
| import useFilter from './useFilters'; | ||
|
|
||
| function showCheckboxes(draft: boolean, dataLength: number): boolean { |
There was a problem hiding this comment.
Suggested change
| function showCheckboxes(draft: boolean, dataLength: number): boolean { | |
| function shouldShowCheckboxes(draft: boolean, dataLength: number): boolean { |
fredericvilcot
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developDescription
This PR implements the "Manage Authorized IPs" feature for Manager Private Registry users. It allows users to define IP restrictions for two components: the management interface (Harbor UI) and the registry service. These restrictions cannot be set during registry creation but can be added or updated afterward through the UI.
The feature integrates with existing API endpoints to list, add, update, and remove IP restrictions. The UI now includes a "Manage Authorized IPs" button that opens a page displaying the current IP restrictions. Users can add or remove individual IPs, clear all restrictions, or use filters to manage them more effectively.
Validation is performed using the CIDR format, with a default mask of /32 if not specified. Optional descriptions for each restriction can also be added or modified. Additionally, the "Guide" button links to documentation for IP restrictions. When no restrictions are present, an onboarding page is displayed to guide users.
This update enhances security management by providing a straightforward interface for controlling registry access.
Related