Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zimbra): add external domain #14527

Merged
merged 2 commits into from
Dec 12, 2024
Merged

feat(zimbra): add external domain #14527

merged 2 commits into from
Dec 12, 2024

Conversation

tristanwagner
Copy link
Contributor

@tristanwagner tristanwagner commented Dec 10, 2024 •
edited
Loading

ref: MANAGER-16354

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-16354
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@tristanwagner tristanwagner self-assigned this Dec 10, 2024
@github-actions github-actions bot added universe-web-cloud translation required dependencies Pull requests that update a dependency file feature New feature labels Dec 10, 2024
@tristanwagner tristanwagner marked this pull request as ready for review December 10, 2024 17:31
@tristanwagner tristanwagner requested review from a team as code owners December 10, 2024 17:31
@tristanwagner tristanwagner force-pushed the feat/MANAGER-16354 branch 2 times, most recently from 8b50215 to edc671e Compare December 11, 2024 08:36
ghyenne
ghyenne previously approved these changes Dec 11, 2024
View reviewed changes
stif59100
stif59100 previously approved these changes Dec 11, 2024
View reviewed changes
@tristanwagner tristanwagner changed the title feat(zimbra): finalize add external domain feat(zimbra): add external domain Dec 11, 2024
@tristanwagner
Copy link
Contributor Author

text contents needs some updates, waiting for it

@tristanwagner tristanwagner dismissed stale reviews from stif59100 and ghyenne via bdd459d December 12, 2024 08:17
@tristanwagner tristanwagner force-pushed the feat/MANAGER-16354 branch 2 times, most recently from bdd459d to 7259d08 Compare December 12, 2024 11:01
ghyenne
ghyenne previously approved these changes Dec 12, 2024
View reviewed changes
ghyenne
ghyenne previously approved these changes Dec 12, 2024
View reviewed changes
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 12, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 12, 2024
@stif59100 stif59100 changed the base branch from master to release/hosting-collaboration-w51 December 12, 2024 16:42
@tristanwagner
feat(zimbra): add external domain (#14527)
6ecbed8 
ref: MANAGER-16354

Signed-off-by: Tristan WAGNER <[email protected]>

fix(i18n): add missing translations [CDS 151]

Signed-off-by: CDS Translator Agent <[email protected]>
@tristanwagner
feat(zimbra): add domain config recommended/expert (#14539)
7431dec 
ref: MANAGER-16374

Signed-off-by: Tristan WAGNER <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud

@stif59100 stif59100 merged commit 7bc1390 into release/hosting-collaboration-w51 Dec 12, 2024
12 of 14 checks passed
@stif59100 stif59100 deleted the feat/MANAGER-16354 branch December 12, 2024 16:53
@stif59100 stif59100 mentioned this pull request Dec 13, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stif59100 stif59100 stif59100 approved these changes

@SimonChaumet SimonChaumet SimonChaumet approved these changes

@ghyenne ghyenne ghyenne left review comments

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 was automatically assigned from ovh/team-manager-dev-angularjs

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien was automatically assigned from ovh/team-manager-dev-angularjs

Assignees

@tristanwagner tristanwagner

Labels
dependencies Pull requests that update a dependency file feature New feature quality check: ok translation required universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tristanwagner @SimonChaumet @ghyenne @stif59100