Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vcd): disable confirm button on update requests #14591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(vcd): disable confirm button on update requests #14591

wants to merge 1 commit into from
+17 −7

Conversation

pauldkn
Copy link
Contributor

@pauldkn pauldkn commented Dec 16, 2024

ref: MANAGER-16472

Question Answer
Branch? release/enabler-hpc-w51
Bug fix? yes
New feature? no
Breaking change? no
Tickets fix/MANAGER-16472
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@pauldkn pauldkn requested review from a team as code owners December 16, 2024 11:10
@pauldkn pauldkn requested review from kqesar, frenautvh, oalkabouss, ghyenne and mhelhali-soufien and removed request for a team December 16, 2024 11:10
@github-actions github-actions bot added the bug Something isn't working label Dec 16, 2024
@pauldkn pauldkn force-pushed the fix/MANAGER-16472 branch 2 times, most recently from 48877e7 to bdaf5f5 Compare December 17, 2024 08:50
@pauldkn pauldkn changed the title fix(vcd): fix enabled button on update requests fix(vcd): disable confirm button on update requests Dec 17, 2024
@tibs245 tibs245 force-pushed the release/enabler-hpc-w51 branch from b7e66e8 to 0916c1c Compare December 17, 2024 09:15
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 17, 2024
Base automatically changed from release/enabler-hpc-w51 to master December 17, 2024 11:20
fix(vcd): disable confirm button on update requests
4e79080 
ref: MANAGER-16472
desc: prevent multiple requests on update name or description

Signed-off-by: Paul Dickerson <[email protected]>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 17, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pauldkn