Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web.domain): eligibility rules project #14608

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat(web.domain): eligibility rules project #14608

wants to merge 5 commits into from

Conversation

ghyenne
Copy link
Contributor

@ghyenne ghyenne commented Dec 17, 2024

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15265
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

It's the eligibility rules (domain owner)

Related

@ghyenne ghyenne requested a review from a team as a code owner December 17, 2024 08:29
@ghyenne ghyenne changed the title Feat/eligibility feat(web.domain): eligibility rules project Dec 17, 2024
Antony MARION added 5 commits December 17, 2024 09:43
@ghyenne
feat(web): add contact management tab eligibility
1834f94 
ref: MANAGER-15829

Signed-off-by: Antony MARION <[email protected]>
@ghyenne
feat(web): add guide link for eligibility
460a54d 
ref: MANAGER-15875

Signed-off-by: Antony MARION <[email protected]>
@ghyenne
feat(web): add eligibility link
39022f7 
ref: MANAGER-15827

Signed-off-by: Antony MARION <[email protected]>
@ghyenne
feat(web): display nic for all and oui message
b612c4f 
ref: MANAGER-16120

Signed-off-by: Antony MARION <[email protected]>
@ghyenne
feat(web): add external link to contact changes
a48d545 
ref: MANAGER-15958

Signed-off-by: Antony MARION <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 17, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature translation required universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ghyenne